vapor-ware / synse-server

An HTTP API for monitoring and controlling physical and virtual devices
https://synse.readthedocs.io/en/latest/server/intro/
GNU General Public License v3.0
39 stars 11 forks source link

server does not fail if invalid cert is specified for grpc transport #388

Closed edaniszewski closed 4 years ago

edaniszewski commented 4 years ago

By "invalid", I mean the cert does not exist. This is because the cert is not checked for presence and is instead just passed right to the client constructor. This happens in a block where we trap errors and instead of failing, let them pass through so we can try again later. The intent being that if we fail to connect, it doesn't terminate the server.

It looks like two things could happen here:

timestamp='2020-04-09T19:04:02.803746Z' logger='synse_server.plugin' level='warning' event='failed to register configured plugin - will attempt re-registering later' address='emulator-plugin:5001' protocol='tcp' error=FileNotFoundError(2, 'No such file or directory')