search

vapor-ware / synse-server

An HTTP API for monitoring and controlling physical and virtual devices
https://synse.readthedocs.io/en/latest/server/intro/
GNU General Public License v3.0
39 stars 11 forks source link

replace structlog with containerlog #448

Closed edaniszewski closed 2 years ago

edaniszewski commented 2 years ago

This PR:

We come full circle. Containerlog was written to be more peformant because the perf testing on synse-server showed logging was adding a non-trivial amount to request latency. Now, containerlog can hopefully improve that request latency a little bit (:

There is one caveat here - I had to do some real Dockerfile surgery. I'm not sure whats up, but building locally, the docker image just straight up failed. I think the new image isn't as streamlined, but it actually works. I think it'd be good for someone to test the docker build out of vapor-ware's develop branch to confirm/refute whether what I'm seeing is actually true, or if it could be some misconfiguration on my machine. Happy to take out the Dockerfile changes if they aren't actually needed.

fixes #399

MatthewHink commented 2 years ago

Thumbs up emoji? Really? Kiss my ass fool.