Closed ffried closed 6 months ago
This currently depends on https://github.com/swift-server-community/APNSwift/pull/195 to be free of warnings, but in general all types should be safe to use across threads.
@0xTim Good point. I had to make the class final
however (otherwise, @unchecked
would still be necessary). It shouldn't break anything, though, since it was never open
- so no subclasses can exist outside of the module.
Also, I removed the unused lock from Application.APNS
.
Attention: Patch coverage is 84.00000%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 89.39%. Comparing base (
c1f1030
) to head (fc65dcc
). Report is 1 commits behind head on main.
@0xTim Done
@ffried Finally can you update the test workflow - I think the reusable workflow branch has been merged so you can point to main now (like Vapor again)
@0xTim Also done
Thanks, we're good to go!
Thanks Team!
These changes are now available in 4.1.0
This adds
Sendable
conformances to all types in this library.