search

vapor / apns

Helpful extensions and abstractions for using APNSwift
MIT License
115 stars 30 forks source link

Container Identifiers #58

Closed dimitribouniol closed 1 month ago

dimitribouniol commented 4 months ago

These changes are now available in 4.2.0

To help users who need to configure a production and development container, added two new containerIDs: production and development. Also added documentation and clarified how the default ID is used, which isn't always the default depending on how use is called.

Note: Since this is new, I went with development instead of sandbox here because all of Apple's documentation refers to it as the development environment. We should probably add .development and deprecate .sandbox in APNSwift as well.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (98ba2f2) to head (965e0b2). Report is 2 commits behind head on main.

Files Patch % Lines
Sources/VaporAPNS/Application+APNS.swift 0.00% 21 Missing :warning:
Sources/VaporAPNS/APNSContainerID.swift 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## =========================================== - Coverage 89.39% 64.44% -24.95% =========================================== Files 4 4 Lines 66 90 +24 =========================================== - Hits 59 58 -1 - Misses 7 32 +25 ``` | [Files](https://app.codecov.io/gh/vapor/apns/pull/58?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/VaporAPNS/APNSContainers.swift](https://app.codecov.io/gh/vapor/apns/pull/58?src=pr&el=tree&filepath=Sources%2FVaporAPNS%2FAPNSContainers.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9WYXBvckFQTlMvQVBOU0NvbnRhaW5lcnMuc3dpZnQ=) | `86.84% <ø> (-0.34%)` | :arrow_down: | | [Sources/VaporAPNS/APNSContainerID.swift](https://app.codecov.io/gh/vapor/apns/pull/58?src=pr&el=tree&filepath=Sources%2FVaporAPNS%2FAPNSContainerID.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9WYXBvckFQTlMvQVBOU0NvbnRhaW5lcklELnN3aWZ0) | `33.33% <0.00%> (-66.67%)` | :arrow_down: | | [Sources/VaporAPNS/Application+APNS.swift](https://app.codecov.io/gh/vapor/apns/pull/58?src=pr&el=tree&filepath=Sources%2FVaporAPNS%2FApplication%2BAPNS.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9WYXBvckFQTlMvQXBwbGljYXRpb24rQVBOUy5zd2lmdA==) | `47.72% <0.00%> (-43.58%)` | :arrow_down: |