search

vapor / async-kit

Sugary extensions for the SwiftNIO library
MIT License
71 stars 25 forks source link

Add `shutdownAsync` #109

Closed 0xTim closed 3 months ago

0xTim commented 3 months ago

These changes are now available in 1.20.0

Even calling Dispatch's .wait() can cause the concurrency pool to deadlock meaning the connection pool never returns. This provides a proper async version of shutdown().

Annotates the offending functions with @noasync

See https://swift-open-source.slack.com/archives/C9MMT6VGB/p1722432257179729 for more context

MahdiBM commented 3 months ago

The CI failures seem to be legit at a glance? I'll rerun just to see what happens, they failed in 1-3 mins anyway.

0xTim commented 3 months ago

Yeah they are, fixing them now