vapor / async-kit

Sugary extensions for the SwiftNIO library
MIT License
71 stars 25 forks source link

Enable code coverage. #58

Closed kylebrowning closed 4 years ago

kylebrowning commented 4 years ago

Attempting to enable code coverage for async-kit

Checklist

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@094dad1). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #58   +/-   ##
========================================
  Coverage          ?   92.8%           
========================================
  Files             ?      13           
  Lines             ?     584           
  Branches          ?       0           
========================================
  Hits              ?     542           
  Misses            ?      42           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 094dad1...f84d376. Read the comment docs.

0xTim commented 4 years ago

@kylebrowning is there any particular reason you did the codecov step as a separate job instead of just adding it to the existing bionic one?

kylebrowning commented 4 years ago

@0xTim It was originally a part of the bionic, but just incase the step failed, and since they are run in parallel, @tanner0101 suggested to move to another step, and I had no preference.