calebkleveter commented 4 years ago

The EventLoopFutureQueue.ContinueError.previousError case will now be flattened when printed.

codecov-io commented 4 years ago

Codecov Report

Merging #62 into master will decrease coverage by 0.91%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   94.44%   93.53%   -0.92%     
==========================================
  Files          23       23              
  Lines        1026     1036      +10     
==========================================
  Hits          969      969              
- Misses         57       67      +10

Impacted Files	Coverage Δ
...syncKit/EventLoopFuture/EventLoopFutureQueue.swift	`70.58% <0.00%> (-29.42%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f145cf...3760f24. Read the comment docs.

MrLotU commented 4 years ago

Of course you push the test right before I comment....

calebkleveter commented 4 years ago

Also don't see the point of mentioning Slack here

I'm just being snarky. We can remove it. 😄

MrLotU commented 4 years ago

Please do. Don't think it adds much in the Vapor context. Might confuse people since this code has nothing to do with Slack, but the mention might give people the impression that it does.

calebkleveter commented 4 years ago

@MrLotU Done.

MrLotU commented 4 years ago

It's still in the actual code, which is what I was talking about 😉 @calebkleveter https://github.com/vapor/async-kit/pull/62/files#diff-8a837dc9e0473ac167778adcd42301f0R31

gwynne commented 4 years ago

@MrLotU It's fine as is 🙂

tanner0101 commented 4 years ago

These changes are now available in 1.0.1

vapor / async-kit

Conform EventLoopFutureQueue.ContinueError to CustomStringConvertible #62

Codecov Report