thuotdwz commented 4 years ago

This is not necessary and causes error in SQLiteKit: The package product 'SQLiteNIO' requires minimum platform version 13.0 for the iOS platform, but this target supports 8.0

codecov-commenter commented 4 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files          23       23           
  Lines        1182     1182           
=======================================
  Hits         1118     1118           
  Misses         64       64

Flag	Coverage Δ
#unittests	`94.58% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 635a259...b1b91ae. Read the comment docs.

0xTim commented 4 years ago

@thuotdwz this was a deliberate decision for all Vapor 4 packages and dependencies. Having to retroactively do this (for instance in the case that something ends up relying on Crypto or some other future SSWG package) is a major breaking change so we'd rather constrain it for the release before rather than backing ourselves into a corner down the line.

tanner0101 commented 4 years ago

See reasoning here https://github.com/vapor/sqlite-nio/pull/18

vapor / async-kit

Remove unnecessary platforms minimum #66

Codecov Report