vapor / async-kit

Sugary extensions for the SwiftNIO library
MIT License
71 stars 25 forks source link

Fix bug related to swift change in error string conversion #68

Closed MrLotU closed 4 years ago

MrLotU commented 4 years ago

Due to a change in Swift, all Errors became CustomStringConvertible by virtue of implicit bridging with NSError. The check for CustomStringConvertible conformance has been removed. This restores the previous behavior and makes the tests pass again.

Unblocks #67

codecov-commenter commented 4 years ago

Codecov Report

Merging #68 into master will increase coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   94.58%   94.66%   +0.07%     
==========================================
  Files          23       23              
  Lines        1182     1180       -2     
==========================================
- Hits         1118     1117       -1     
+ Misses         64       63       -1     
Flag Coverage Δ
#unittests 94.66% <ø> (+0.07%) :arrow_up:
Impacted Files Coverage Δ
...syncKit/EventLoopFuture/EventLoopFutureQueue.swift 100.00% <ø> (+2.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 635a259...060c7c3. Read the comment docs.

calebkleveter commented 4 years ago

I can't reproduce this locally on the latest versions of Catalina, Xcode, and Swift. 🤔

MrLotU commented 4 years ago

CI fails on MacOS right here: https://github.com/vapor/async-kit/pull/67/checks?check_run_id=730187317#step:4:229 I can see if I can repro locally 🤔

gwynne commented 4 years ago

Oh look, weird magical unwanted NSError bridging strikes again...

gwynne commented 4 years ago

@MrLotU Suggested PR body for release notes:


tanner0101 commented 4 years ago

These changes are now available in 1.1.1