Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f6f92e6). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage        ?   77.24%           
=======================================
  Files           ?       28           
  Lines           ?     1806           
  Branches        ?        0           
=======================================
  Hits            ?     1395           
  Misses          ?      411           
  Partials        ?        0

Flag	Coverage Δ
unittests	`77.24% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6f92e6...fb9a862. Read the comment docs.

0xTim commented 3 years ago

@lukasa any idea why 5.2 is not reporting the thread name?

Lukasa commented 3 years ago

Looks like https://bugs.swift.org/browse/SR-11720. Seems like it got fixed in 5.3.

0xTim commented 3 years ago

@calebkleveter Guess we either need to ignore the test on 5.2 or try and test it another way. I'm happy to ignore it on 5.2

calebkleveter commented 3 years ago

I would just ignore the test case and merge it.

0xTim commented 3 years ago

That's going to break the build and any PRs going forward though right? I think the test case should be wrapped in a compiler check

calebkleveter commented 3 years ago

Good point. I'm not at my computer right now, but I'll add that once I get a chance.

VaporBot commented 3 years ago

These changes are now available in 1.9.1

vapor / async-kit

Submit Closure of .tryFuture to Event Loop Thread #85

Codecov Report