gwynne commented 2 years ago

Additional changes:

Reimplement EventLoopGroup.performWithTask(_:) in terms of EventLoop.performWithTask(_:).
Match implementations to NIO's code patterns for consistency.
Major cleanup of AsyncKit source and tests layout (no functional changes).
Better tests for the performWithTask() utilities; somehow we missed that it was originally implemented only on ELG and not EL, even though the exist test should have shown that by not even compiling successfully.
Improvements to the CI workflows to match latest advances.

Semver-minor release due to the addition of the missing public API.

codecov-commenter commented 2 years ago

Codecov Report

Merging #87 (a66e43e) into main (748c026) will increase coverage by 1.54%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   61.42%   62.96%   +1.54%     
==========================================
  Files          16       19       +3     
  Lines        1195     1199       +4     
==========================================
+ Hits          734      755      +21     
+ Misses        461      444      -17

Flag	Coverage Δ
unittests	`62.96% <83.33%> (+1.54%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/AsyncKit/EventLoop/EventLoopGroup+Throwing.swift	`100.00% <ø> (ø)`
...ces/AsyncKit/EventLoopFuture/Future+Nonempty.swift	`100.00% <ø> (ø)`
...syncKit/EventLoopFuture/Future+Miscellaneous.swift	`75.00% <75.00%> (ø)`
...ces/AsyncKit/EventLoop/EventLoop+Concurrency.swift	`100.00% <100.00%> (ø)`
...syncKit/EventLoop/EventLoopGroup+Concurrency.swift	`100.00% <100.00%> (ø)`
Sources/AsyncKit/EventLoopFuture/Future+Try.swift	`100.00% <100.00%> (ø)`
...AsyncKit/EventLoopFuture/Future+Conjunctions.swift	`6.83% <0.00%> (+0.28%)`	:arrow_up:
...syncKit/EventLoopFuture/EventLoopFutureQueue.swift	`100.00% <0.00%> (+2.17%)`	:arrow_up:
...s/AsyncKit/EventLoopFuture/Future+Collection.swift	`100.00% <0.00%> (+3.12%)`	:arrow_up:
...ncKit/ConnectionPool/EventLoopConnectionPool.swift	`94.40% <0.00%> (+3.72%)`	:arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 748c026...a66e43e. Read the comment docs.

VaporBot commented 2 years ago

These changes are now available in 1.11.0

vapor / async-kit

Add `EventLoop.performWithTask(_:)` to complement `EventLoopGroup.performWithTask(_:)` #87

Codecov Report