simplified codable reflection algorithm - Githubissues

vapor / core

🌎 Utility package containing tools for byte manipulation, Codable, OS APIs, and debugging.

MIT License

82 stars 50 forks source link

simplified codable reflection algorithm #162

Closed tanner0101 closed 5 years ago

tanner0101 commented 6 years ago

This PR includes a new Codable reflection algorithm that has a couple of benefits over the old one:

1: Reduces the need for ReflectionDecodable conformance in many places (like custom structs, int-backed enums, and many primitive types).
2: Requires WriteableKeyPath instead of KeyPath which should prevent user error (i.e., filter(\.name.count == 2).
3: Has O(n) runtime. (Current is O(n^2))
4: Less code :) (this PR shows more lines added but there is a lot of unnecessary code that can be deleted if we merge this).

Unfortunately this is a breaking change, so it will have to wait until Core 4.0. Opening this now though so that the code can be preserved.

tanner0101 commented 5 years ago

This has been added here: https://github.com/vapor/codable-kit/pull/1