2 Warnings during linux build with 5.0.x swift

vapor / core

🌎 Utility package containing tools for byte manipulation, Codable, OS APIs, and debugging.

MIT License

82 stars 50 forks source link

2 Warnings during linux build with 5.0.x swift #204

Open dougreid72 opened 5 years ago

dougreid72 commented 5 years ago

I am not sure if this is a linux, swift, or core issue.

Core/Process+Execute.swift:163:17: warning: 'launchPath' is deprecated: renamed to 'executableURL'

Core/Process+Execute.swift:167:17: warning: 'launch()' is deprecated: renamed to 'run'

Do not get these warnings in Xcode.

Version 3.9.0 of Core

tanner0101 commented 5 years ago

Hmm....maybe due to 5.0 having a better compatibility layer with Swift 4.1 mode on macOS? We should be able to silence the warnings with a combination of #if os and #if compiler, but this seems like it should be fixed in Swift / core libs foundation itself.

dougreid72 commented 5 years ago

Should I put in a ticket with swift?

tanner0101 commented 5 years ago

Yeah that would be great. :)

dougreid72 commented 5 years ago

I created an issue at bugs.swift.org.