vapor / fluent-kit

Swift ORM (queries, models, and relations) for NoSQL and SQL databases
MIT License
218 stars 116 forks source link

MySQL CONSTRAINT/KEY logic result in error when trying to delete a constraint #491

Closed kevinzhow closed 2 years ago

kevinzhow commented 2 years ago

https://github.com/vapor/fluent-kit/blob/9d47c328bf83999968c12a3bc94ead1d706ad4a9/Sources/FluentSQL/SQLSchemaConverter.swift#L280

This CONSTRAINT/KEY logic result in this issue https://github.com/vapor/fluent/issues/722 which will made deleteConstraint didn't work

Wondering why we have this logic and do we have any unit test on this?

gwynne commented 2 years ago

This was handled more comprehensively in #522