vapor / fluent-kit

Swift ORM (queries, models, and relations) for NoSQL and SQL databases
MIT License
218 stars 116 forks source link

Some tests not being executed #518

Closed nashysolutions closed 2 years ago

nashysolutions commented 2 years ago

Tests within this function are not executing. John has a great solution for preventing this situation here which might be useful.

public func testAll() throws {
        try self.testAggregate()
        try self.testArray()
        try self.testBatch()
        try self.testChild()
        try self.testChildren()
        try self.testCodable()
        try self.testChunk()
        try self.testCompositeID()
        try self.testCRUD()
        try self.testEagerLoad()
        try self.testEnum()
        try self.testFilter()
        try self.testGroup()
        try self.testID()
        try self.testJoin()
        try self.testMiddleware()
        try self.testMigrator()
        try self.testModel()
        try self.testOptionalParent()
        try self.testPagination()
        try self.testParent()
        try self.testPerformance()
        try self.testRange()
        try self.testSchema()
        try self.testSet()
        try self.testSiblings()
        try self.testSoftDelete()
        try self.testSort()
        try self.testSQL()
        try self.testTimestamp()
        try self.testTransaction()
        try self.testUnique()
}
0xTim commented 2 years ago

@nashysolutions where are you expecting these tests to be executed? These aren't executed as part of FluentKit but they're used by the different drivers to ensure that they work (means we have a centralised set of tests rather than having to duplicate them for each driver)

nashysolutions commented 2 years ago

If this is the setup you are happy with then of course that's fine. :) Was just a bit surprised when they didn't execute in fluentkit.