search

vapor / fluent-kit

Swift ORM (queries, models, and relations) for NoSQL and SQL databases
MIT License
218 stars 116 forks source link

Remove several sources of fatal errors from @Group #531

Closed gwynne closed 2 years ago

gwynne commented 2 years ago

This removes most of the easier ways to cause fatal errors (esp. from user input) from @Group's implementation.

Fixes #530

codecov-commenter commented 2 years ago

Codecov Report

Merging #531 (a0ad56d) into main (7fc64d3) will increase coverage by 0.03%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   45.68%   45.72%   +0.03%     
==========================================
  Files         101      101              
  Lines        5733     5737       +4     
==========================================
+ Hits         2619     2623       +4     
  Misses       3114     3114
Flag Coverage Δ
unittests 45.72% <85.71%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/FluentKit/Properties/Group.swift 68.53% <85.71%> (+1.48%) :arrow_up:
VaporBot commented 2 years ago

These changes are now available in 1.35.1