search

vapor / fluent-kit

Swift ORM (queries, models, and relations) for NoSQL and SQL databases
MIT License
218 stars 116 forks source link

Revised error handling in Encodable conformance for Fields #538

Closed gwynne closed 2 years ago

gwynne commented 2 years ago

This allows the fixes in vapor/postgres-kit#234 and vapor/mysql-kit#313 to work correctly and adds testing of the affected functionality.

codecov-commenter commented 2 years ago

Codecov Report

Merging #538 (2b4dd40) into main (38670d2) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #538 +/- ## ======================================= Coverage 45.72% 45.72% ======================================= Files 101 101 Lines 5737 5737 ======================================= Hits 2623 2623 Misses 3114 3114 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `45.72% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/vapor/fluent-kit/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/FluentKit/Model/Fields+Codable.swift](https://codecov.io/gh/vapor/fluent-kit/pull/538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvTW9kZWwvRmllbGRzK0NvZGFibGUuc3dpZnQ=) | `79.54% <100.00%> (ø)` | |
VaporBot commented 2 years ago

These changes are now available in 1.35.2