Closed gwynne closed 1 year ago
@rausnitz As in your original PR, I only implemented this logic for INSERT
queries specifically, but UPDATE
queries are also affected by the same issue. The same trick can be applied there as well, if it would be of additional benefit for your use case. (Fortunately SELECT
queries already base their ordering on the fields
, and DELETE
queries don't specify columns at all.)
Edit: Went ahead and did it for UPDATE
queries too. Might as well be consistent.
Merging #557 (a4d7d5c) into main (0fdeff6) will increase coverage by
0.09%
. The diff coverage is100.00%
.
This is an updated version of #556 by @rausnitz which updates the generation of
INSERT
queries to be both deterministic and more performant by eliding pointless repetition of the Fluent -> SQL conversion of the field list.Additional kudos for @rausnitz for his enthusiasm, which inspired me to take another hard look at the existing logic!
Closes #543