search

vapor / fluent-kit

Swift ORM (queries, models, and relations) for NoSQL and SQL databases
MIT License
217 stars 116 forks source link

Explicitly log migration errors #567

Closed gwynne closed 1 year ago

gwynne commented 1 year ago

This ensures errors thrown during migration (both prepare and revert) are fully logged regardless of the behavior of calling code.

codecov-commenter commented 1 year ago

Codecov Report

Merging #567 (49da144) into main (04691f8) will decrease coverage by 0.07%. The diff coverage is 0.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #567 +/- ## ========================================== - Coverage 47.59% 47.53% -0.07% ========================================== Files 106 106 Lines 4700 4706 +6 ========================================== Hits 2237 2237 - Misses 2463 2469 +6 ``` | [Impacted Files](https://app.codecov.io/gh/vapor/fluent-kit/pull/567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/FluentKit/Migration/Migrator.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvTWlncmF0aW9uL01pZ3JhdG9yLnN3aWZ0) | `0.00% <0.00%> (ø)` | |
VaporBot commented 1 year ago

These changes are now available in 1.42.4