Closed RandomHashTags closed 1 year ago
Merging #568 (3e51559) into main (2d7dce5) will decrease coverage by
0.25%
. The diff coverage is0.00%
.
Closing due to the CustomStringConvertible
property conformance and associated implementation not really meaning to be there. A more accurate reasoning would be: I hold the same opinion shared by Gwynne during discussion.
While I do support this pull request, I will not continue pursuing implementation due to it being a legacy design.
Some properties already conform to this protocol, but I found some that do not. This fixes a case where getting the description of an
AnyProperty
will not be in the correct format, and also missing the key.Changes
OptionalBooleanProperty
,BooleanProperty
,OptionalFieldProperty
,EnumProperty
, andOptionalEnumProperty
BooleanPropertyFormat
Examples
@Enum
would returnFluentKit.EnumProperty<X, Y>
. Now returns@X.Enum<Y>(key: Z)
@OptionalField
would returnFluentKit.OptionalFieldProperty<X, Y>
. Now returns@X.OptionalField<Y>(key: Z)
Unit Testing
FluentKitTests.testAnyModelDescriptionFormatHasNotChanged
, even though the data is the same, just in a different order (this test also fails even before this commit)