search

vapor / fluent-kit

Swift ORM (queries, models, and relations) for NoSQL and SQL databases
MIT License
217 stars 116 forks source link

conform FieldKey to Sendable #600

Closed jaredh159 closed 7 months ago

jaredh159 commented 7 months ago

There are perhaps other types that should be audited for Sendable-ity, but I'm not sure if there's a coordinated effort around that. I'm updating a Vapor app getting it ready for Swift 6 with all concurrency warnings turned to the max, and seeing warnings related to my usage of FieldKey, seems like an obvious candidate to be Sendable, although I could be missing some subtle nuance of Semver or something like that.

gwynne commented 7 months ago

This will be superseded by #601

jaredh159 commented 7 months ago

thanks @gwynne! happy to see a more wide ranging effort to add Sendable. seems like the whole ecosystem is going to be working on this type of thing.

can you comment at all on when #601 might be complete, or when a release might be available?

also, is there similar work happening in other Vapor modules? I'm seeing more warnings from other things that could trivially be made Sendable like HttpHeader and some core Vapor primitives.

0xTim commented 7 months ago

@jaredh159 I'm pretty sure most Vapor stuff should be ready outside of Fluent now. There are a couple in Vapor we can't fix, but most are done. Which are you seeing?

jaredh159 commented 7 months ago

@0xTim i might have spoke too soon on the vapor warnings, i wasn't at 4.93.0 yet when i wrote that comment, but have updated since and i think they're mostly (or all) gone, just the ones from fluent-kit remained. if i see something from vapor core i'll let you know