Tidy up FluentKit - Githubissues

gwynne commented 6 months ago

These changes are now available in 1.48.4

A few changes that were missed in previous cleanup and update passes:

Previously missing async versions of some Database methods are now present.
All SQLDatabase methods are now correctly forwarded when using Database.logging(to:).
All versions of the .sql(raw:) utility for directly embedding raw SQL into Fluent queries have been renamed to .sql(unsafeRaw:) to better emphasize the inadvisability of their use. The old name still works but is now deprecated.
SQLSchemaConverter is now very infinitesimally faster.
Fluent's tests now include the appropriate tests from SQLKit as well.
Removed some unneeded Sendable warning workarounds, should slightly improve performance.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 25.35211% with 106 lines in your changes are missing coverage. Please review.

Project coverage is 24.73%. Comparing base (ed4cfa9) to head (308ddcc).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #609 +/- ## ========================================== - Coverage 24.99% 24.73% -0.26% ========================================== Files 150 149 -1 Lines 8573 8590 +17 ========================================== - Hits 2143 2125 -18 - Misses 6430 6465 +35 ``` | [Files](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/FluentBenchmark/FluentBenchmarker.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentBenchmark%2FFluentBenchmarker.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRCZW5jaG1hcmsvRmx1ZW50QmVuY2htYXJrZXIuc3dpZnQ=) | `0.00% <ø> (ø)` | | | [Sources/FluentKit/Database/DatabaseID.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentKit%2FDatabase%2FDatabaseID.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvRGF0YWJhc2UvRGF0YWJhc2VJRC5zd2lmdA==) | `0.00% <ø> (ø)` | | | [Sources/FluentKit/FluentError.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentKit%2FFluentError.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvRmx1ZW50RXJyb3Iuc3dpZnQ=) | `0.00% <ø> (ø)` | | | [...urces/FluentSQL/SQLJSONColumnPath+Deprecated.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentSQL%2FSQLJSONColumnPath%2BDeprecated.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRTUUwvU1FMSlNPTkNvbHVtblBhdGgrRGVwcmVjYXRlZC5zd2lmdA==) | `0.00% <ø> (ø)` | | | [Sources/FluentSQL/SQLSchemaConverter.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentSQL%2FSQLSchemaConverter.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRTUUwvU1FMU2NoZW1hQ29udmVydGVyLnN3aWZ0) | `62.99% <100.00%> (-0.57%)` | :arrow_down: | | [Sources/FluentBenchmark/Tests/ChildTests.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentBenchmark%2FTests%2FChildTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRCZW5jaG1hcmsvVGVzdHMvQ2hpbGRUZXN0cy5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [Sources/FluentBenchmark/Tests/FilterTests.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentBenchmark%2FTests%2FFilterTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRCZW5jaG1hcmsvVGVzdHMvRmlsdGVyVGVzdHMuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [Sources/FluentKit/Query/Builder/QueryBuilder.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentKit%2FQuery%2FBuilder%2FQueryBuilder.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvUXVlcnkvQnVpbGRlci9RdWVyeUJ1aWxkZXIuc3dpZnQ=) | `73.46% <71.42%> (ø)` | | | [Sources/FluentKit/Schema/DatabaseSchema.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentKit%2FSchema%2FDatabaseSchema.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvU2NoZW1hL0RhdGFiYXNlU2NoZW1hLnN3aWZ0) | `54.54% <0.00%> (ø)` | | | [Sources/FluentBenchmark/Tests/SQLTests.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree&filepath=Sources%2FFluentBenchmark%2FTests%2FSQLTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRCZW5jaG1hcmsvVGVzdHMvU1FMVGVzdHMuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | ... and [10 more](https://app.codecov.io/gh/vapor/fluent-kit/pull/609?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | |

gwynne commented 6 months ago

SQLite integration tests will pass once vapor/fluent-sqlite-driver#90 is merged

vapor / fluent-kit

Tidy up FluentKit #609

Codecov Report