search

vapor / fluent-kit

Swift ORM (queries, models, and relations) for NoSQL and SQL databases
MIT License
217 stars 116 forks source link

Add async APIs for shutting down the databases #614

Closed 0xTim closed 3 months ago

0xTim commented 3 months ago

These changes are now available in 1.49.0

To enable removing calls to .wait() in the connection pools when in an async context

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 24.78%. Comparing base (cff1c3e) to head (22074e2).

Files Patch % Lines
Sources/FluentKit/Database/Databases.swift 0.00% 8 Missing :warning:
Sources/FluentKit/Database/Database.swift 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #614 +/- ## ========================================== - Coverage 24.80% 24.78% -0.03% ========================================== Files 149 149 Lines 8650 8660 +10 ========================================== Hits 2146 2146 - Misses 6504 6514 +10 ``` | [Files](https://app.codecov.io/gh/vapor/fluent-kit/pull/614?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/FluentKit/Database/Database.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/614?src=pr&el=tree&filepath=Sources%2FFluentKit%2FDatabase%2FDatabase.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvRGF0YWJhc2UvRGF0YWJhc2Uuc3dpZnQ=) | `73.68% <0.00%> (-8.67%)` | :arrow_down: | | [Sources/FluentKit/Database/Databases.swift](https://app.codecov.io/gh/vapor/fluent-kit/pull/614?src=pr&el=tree&filepath=Sources%2FFluentKit%2FDatabase%2FDatabases.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRLaXQvRGF0YWJhc2UvRGF0YWJhc2VzLnN3aWZ0) | `0.00% <0.00%> (ø)` | |