vapor / fluent-mongo-driver

MongoDB support for Fluent built on MongoKittten.
MIT License
25 stars 11 forks source link

Add support for sorting joined tables #53

Open kstefanou52 opened 1 year ago

kstefanou52 commented 1 year ago

Issue

Mongo driver didn't support to query results with sorting option for joined tables as describing here.

Enable sorting for joined tables

Joannis commented 1 year ago

@gwynne is it doable to add these type of tests to FluentKit?

codecov-commenter commented 1 year ago

Codecov Report

Merging #53 (ec79b7e) into main (a4237b9) will increase coverage by 2.34%. Report is 1 commits behind head on main. The diff coverage is 95.65%.

:exclamation: Current head ec79b7e differs from pull request most recent head 000a562. Consider uploading reports for the commit 000a562 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== + Coverage 72.59% 74.93% +2.34% ========================================== Files 20 20 Lines 686 826 +140 ========================================== + Hits 498 619 +121 - Misses 188 207 +19 ``` | [Files](https://app.codecov.io/gh/vapor/fluent-mongo-driver/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [...ources/FluentMongoDriver/DatabaseQuery+Mongo.swift](https://app.codecov.io/gh/vapor/fluent-mongo-driver/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRNb25nb0RyaXZlci9EYXRhYmFzZVF1ZXJ5K01vbmdvLnN3aWZ0) | `100.00% <100.00%> (+3.22%)` | :arrow_up: | | [Sources/FluentMongoDriver/MongoDB+Join.swift](https://app.codecov.io/gh/vapor/fluent-mongo-driver/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRNb25nb0RyaXZlci9Nb25nb0RCK0pvaW4uc3dpZnQ=) | `69.60% <100.00%> (+14.13%)` | :arrow_up: | | [Sources/FluentMongoDriver/MongoDB+Read.swift](https://app.codecov.io/gh/vapor/fluent-mongo-driver/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRNb25nb0RyaXZlci9Nb25nb0RCK1JlYWQuc3dpZnQ=) | `93.18% <100.00%> (+1.07%)` | :arrow_up: | | [Sources/FluentMongoDriver/Sort.swift](https://app.codecov.io/gh/vapor/fluent-mongo-driver/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRNb25nb0RyaXZlci9Tb3J0LnN3aWZ0) | `89.28% <93.75%> (+9.28%)` | :arrow_up: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/vapor/fluent-mongo-driver/pull/53/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)