`.string` migrations results in a 256 length varchar

vapor / fluent-mysql-driver

🖋🐬 Swift ORM (queries, models, relations, etc) built on MySQL.

MIT License

77 stars 52 forks source link

`.string` migrations results in a 256 length varchar #171

Closed 0xTim closed 4 years ago

0xTim commented 4 years ago

When setting up a .string column in MySQL (e.g. here), the column is created as VARCHAR(256) instead of anything longer. I remember a discussion on Discord about making this longer, but it doesn't appear to be the case

tanner0101 commented 4 years ago

Fluent 4 continues to use VARCHAR(255) like Fluent 3 did. I don't remember the discussion about this in Discord, what was the reason behind changing that again?

For reference:

Fluent 4: https://github.com/vapor/fluent-mysql-driver/blob/master/Sources/FluentMySQLDriver/MySQLConverterDelegate.swift#L6
Fluent 3: https://github.com/vapor/mysql-kit/blob/3/Sources/MySQL/SQL/MySQLDataTypeStaticRepresentable.swift#L24