search

vapor / fluent-mysql-driver

🖋🐬 Swift ORM (queries, models, relations, etc) built on MySQL.
MIT License
77 stars 52 forks source link

Shut down the driver's connection pool safely #224

Closed gwynne closed 5 months ago

gwynne commented 5 months ago

These changes are now available in 4.5.1

Specifically, don't use the soft-deprecated AsyncKit API that calls EventLoopFuture.wait() internally; use the one that at least does it with Dispatch (best we can do without changing Fluent's driver interface).

Also updates dependency version requirements.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.87%. Comparing base (26f142d) to head (fc67041).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #224 +/- ## ======================================= Coverage 98.87% 98.87% ======================================= Files 7 7 Lines 266 266 ======================================= Hits 263 263 Misses 3 3 ``` | [Files](https://app.codecov.io/gh/vapor/fluent-mysql-driver/pull/224?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/FluentMySQLDriver/FluentMySQLDriver.swift](https://app.codecov.io/gh/vapor/fluent-mysql-driver/pull/224?src=pr&el=tree&filepath=Sources%2FFluentMySQLDriver%2FFluentMySQLDriver.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRNeVNRTERyaXZlci9GbHVlbnRNeVNRTERyaXZlci5zd2lmdA==) | `100.00% <100.00%> (ø)` | |