Closed pulpn0ir closed 3 years ago
The tests are failing due to unrelated changes.
error: CacheTests.testCacheSet : threw error "invalidValue("bar", Swift.EncodingError.Context(codingPath: [], debugDescription: "Top-level String encoded as string JSON fragment.", underlyingError: nil))"
There seems to be a regression in JSON encoding here. Strangely, the nightly 5.3 builds fine.Besides reporting these I think we should update CI to not depend on nightly builds. @gwynne @0xTim agreed?
@siemensikkema agree, for most things we should probably be testing with lowest supported version (5.2 release) and current release (5.4). It might be beneficial to test against latest master to catch Swift regressions but there's no point testing against a nightly build of a released Swift version
Adds a means to prevent server overloads by limiting the maximum amount of elements returned in a single page.
Application
andRequest
have been extended with setters for page size limits. Set limits using the newly introducedPageLimit
type.This PR depends on: https://github.com/vapor/fluent-kit/pull/412