Clear the Set-Cookie header before appending all the cookies, fixes #339

vapor / http

🚀 Non-blocking, event-driven HTTP built on Swift NIO.

MIT License

240 stars 65 forks source link

Closed joewalsh closed 5 years ago

joewalsh commented 5 years ago

Fix for #339

joewalsh commented 5 years ago

@tanner0101 thanks for the feedback! I added a test and I am willing to re-submit a PR against the 3 branch after this is approved.

tanner0101 commented 5 years ago

Looks like there were some breaking changes in NIO 2 that NIOHPACK needs to be updated for. Once @Lukasa updates that we can re-test and merge.

penny-coin commented 5 years ago

Hey @joewalsh, you just merged a pull request, have a coin!

You now have 1 coins.