search

vapor / jwt

Vapor JWT provider
MIT License
320 stars 67 forks source link

Add Firebase Auth authenticator? #159

Closed petrpavlik closed 1 hour ago

petrpavlik commented 2 hours ago

I've just finished creating a Firebase Auth authenticator build on top JWT 5, and wanted to offer to contribute the code to this repo, since it already contains authenticators for google/microsoft/apple. With that, I do understand that we need to draw a line what will be baked into the main package, and what should be extension packages, so happy to also release it as a standalone extension package.

ptoffy commented 2 hours ago

Hey @petrpavlik, thanks for this! I see no issue with this being added as long as it's in a similar fashion as the other authenticators. In the future it might make sense to rebuild the package's structure in a more generic way, so that people can just add their own authenticators rather than having to fork the repo, but that's still ways down the road as we've just shipped v5

petrpavlik commented 1 hour ago

Thanks! I've copied the google one and applied small modifications to make it work with Firebase Auth, so yes, it is in a similar fashion. Will open PRs later. Also, closing this.