Closed b-nassler closed 7 months ago
Oh, I forgot to also add - can you add a test for this as well?
Attention: Patch coverage is 83.33333%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 82.09%. Comparing base (
38e3144
) to head (750db9d
).
@gwynne Updated, please check 🙂
@gwynne @0xTim Everything should be ok I think. Let me know if I should do anything else. Thanks!
@gwynne Good one! I committed your suggestion
@0xTim You probably saw this but something ran out of memory so it didn't succeed merging
These changes are now available in 1.10.5
This line https://github.com/vapor/leaf-kit/blob/main/Sources/LeafKit/LeafParser/LeafParser.swift#L203 would cause a crash when no parameters are found
Fixed issue that lead to a crash when parameters would be empty in line https://github.com/vapor/leaf-kit/blob/main/Sources/LeafKit/LeafParser/LeafParser.swift#L203