Several very long overdue crash fixes

gwynne commented 1 year ago

Items of note:

Replaced all the assert()s, precondition()s, and fatalError()s with thrown errors as appropriate. Removes almost every source of crashes - especially ones caused by input the user has no control over - in the package.
Fixes #87 (unexpected packets with no active command cause an assertion failure)
Fixes #91 (server error before handshake throws invalidProtocolVersion() instead of the appropriate .server(ERR_Packet))
CI and README updates
Fixes the unit tests so they don't leave stale tables lying around.

With the rewrite finally back to being actively worked on, it became really obvious how easy these fixes were to make even in the existing code, and I decided users shouldn't have to wait any longer for them, even if the rewrite drops the next day.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a92a493). Click here to learn what that means. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #95 +/- ## ======================================= Coverage ? 44.66% ======================================= Files ? 38 Lines ? 3253 Branches ? 0 ======================================= Hits ? 1453 Misses ? 1800 Partials ? 0 ```

VaporBot commented 1 year ago

These changes are now available in 1.6.1

vapor / mysql-nio

Several very long overdue crash fixes #95

Codecov Report