vapor / penny-bot

The code that runs Penny πŸ€–
18 stars 2 forks source link

Cut back on the coin-granting reaction list #105

Closed gwynne closed 1 year ago

gwynne commented 1 year ago

The current list of emoji reactions which grant coins is:

        static let coinSignEmojis = [
            Constants.ServerEmojis.love.name,
            Constants.ServerEmojis.vapor.name,
            Constants.ServerEmojis.coin.name,
            Constants.ServerEmojis.doge.name,
            "πŸͺ™",
            "❀️", "πŸ’™", "πŸ’œ", "🀍", "🀎", "πŸ–€", "πŸ’›", "πŸ’š", "🧑",
            "πŸ’—", "πŸ’–", "πŸ’ž", "❣️", "πŸ’“", "πŸ’˜", "πŸ’", "πŸ’•", "❀️‍πŸ”₯", "πŸ’Ÿ",
            "😍", "😻",
            "πŸš€", "πŸŽ‰", "πŸ’―",
            "πŸ™Œ", "πŸ™ŒπŸ»", "πŸ™ŒπŸΌ", "πŸ™ŒπŸ½", "πŸ™ŒπŸΎ", "πŸ™ŒπŸΏ",
            "πŸ™", "πŸ™πŸ»", "πŸ™πŸΌ", "πŸ™πŸ½", "πŸ™πŸΎ", "πŸ™πŸΏ",
            "πŸ‘Œ", "πŸ‘ŒπŸ»", "πŸ‘ŒπŸΌ", "πŸ‘ŒπŸ½", "πŸ‘ŒπŸΎ", "πŸ‘ŒπŸΏ",
            "πŸ‘", "πŸ‘πŸ»", "πŸ‘πŸΌ", "πŸ‘πŸ½", "πŸ‘πŸΎ", "πŸ‘πŸΏ",
        ]

(per https://github.com/vapor/penny-bot/blob/main/Sources/Penny/Handlers/ReactionHandler/ReactionHandler.swift#L9-L23)

This is now becoming a bit noisy, and people are granting coins without meaning to. I propose this list:

       /// U+1F3FB EMOJI MODIFIER FITZPATRICK TYPE-1-2...TYPE-6
        private static let emojiSkins = ["","\u{1f3fb}","\u{1f3fc}","\u{1f3fd}","\u{1f3fe}","\u{1f3ff}"]
        /// U+2640 FEMALE SIGN, U+2642 MALE SIGN, U+200D ZWJ, U+FE0F VARIATION SELECTOR 16
        private static let emojiGenders = ["", "\u{200d}\u{2640}\u{fe0f}", "\u{200d}\u{2642}\u{fe0f}"]

       static let coinSignEmojis = [
            Constants.ServerEmojis.love.name,
            Constants.ServerEmojis.vapor.name,
            Constants.ServerEmojis.coin.name, "πŸͺ™",
            "❀️", "πŸ’™", "πŸ’œ", "🀍", "🀎", "πŸ–€", "πŸ’›", "πŸ’š", "🧑",
            "🩷", "🩢", "🩡", "πŸ’—", "πŸ’•", "😍", "😻", "πŸŽ‰", "πŸ’―",
        ]
            + emojiSkins.map { "πŸ™Œ\($0)" }
            + emojiSkins.map { "πŸ™\($0)" }
            + emojiSkins.map { "πŸ‘\($0)" }
            + emojiSkins.map { s in emojiGenders.map { g in "πŸ™‡\(s)\(g)" } }

(for the record, this, of course, yields the array ["vaporlove", "vapor", "coin", "πŸͺ™", "❀️", "πŸ’™", "πŸ’œ", "🀍", "🀎", "πŸ–€", "πŸ’›", "πŸ’š", "🧑", "🩷", "🩢", "🩡", "πŸ’—", "πŸ’•", "😍", "😻", "πŸŽ‰", "πŸ’―", "πŸ™Œ", "πŸ™ŒπŸ»", "πŸ™ŒπŸΌ", "πŸ™ŒπŸ½", "πŸ™ŒπŸΎ", "πŸ™ŒπŸΏ", "πŸ™", "πŸ™πŸ»", "πŸ™πŸΌ", "πŸ™πŸ½", "πŸ™πŸΎ", "πŸ™πŸΏ", "πŸ‘", "πŸ‘πŸ»", "πŸ‘πŸΌ", "πŸ‘πŸ½", "πŸ‘πŸΎ", "πŸ‘πŸΏ", "πŸ™‡", "πŸ™‡β€β™€οΈ", "πŸ™‡β€β™‚οΈ", "πŸ™‡πŸ»", "πŸ™‡πŸ»β€β™€οΈ", "πŸ™‡πŸ»β€β™‚οΈ", "πŸ™‡πŸΌ", "πŸ™‡πŸΌβ€β™€οΈ", "πŸ™‡πŸΌβ€β™‚οΈ", "πŸ™‡πŸ½", "πŸ™‡πŸ½β€β™€οΈ", "πŸ™‡πŸ½β€β™‚οΈ", "πŸ™‡πŸΎ", "πŸ™‡πŸΎβ€β™€οΈ", "πŸ™‡πŸΎβ€β™‚οΈ", "πŸ™‡πŸΏ", "πŸ™‡πŸΏβ€β™€οΈ", "πŸ™‡πŸΏβ€β™‚οΈ"])

gwynne commented 1 year ago

For completeness: The new list removes these emoji:

And adds:

0xTim commented 1 year ago

Happy to continue tweaking. I'd say πŸš€ should probably stay and I'm happy to remove πŸ‘ as I think that could cause confusion

ptoffy commented 1 year ago

RIP doge πŸ₯²

tkrajacic commented 1 year ago

Noooooooooo 😭

tkrajacic commented 1 year ago

4

MahdiBM commented 1 year ago

Objections πŸ˜›:

MahdiBM commented 1 year ago

@gwynne @0xTim what is the conclusion on this? :eyes:

0xTim commented 1 year ago

My vote is @gwynne suggestions but remove πŸ‘ and add back πŸš€

MahdiBM commented 1 year ago

Fine but i'm also keeping doge 😁

ptoffy commented 1 year ago

Fine but i'm also keeping doge 😁

Not the hero we deserve, but the hero we need

MahdiBM commented 1 year ago

this is resolved btw, what Gwynne said with Tim and my final changes.