search

vapor / postgres-nio

🐘 Non-blocking, event-driven Swift client for PostgreSQL.
https://api.vapor.codes/postgresnio/documentation/postgresnio/
MIT License
327 stars 75 forks source link

Bump Swift to 5.5 #309

Closed MahdiBM closed 2 years ago

MahdiBM commented 2 years ago

NIO periodically updates their minimum swift version, and with swift 5.7 released, swift 5.4 is soon to be unsupported.

Changes

This PR:

codecov-commenter commented 2 years ago

Codecov Report

Merging #309 (caa7a16) into main (2cad52a) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #309 +/- ## ======================================= Coverage 43.53% 43.53% ======================================= Files 115 115 Lines 9760 9760 ======================================= Hits 4249 4249 Misses 5511 5511 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `43.53% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/vapor/postgres-nio/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [...es/PostgresNIO/Connection/PostgresConnection.swift](https://codecov.io/gh/vapor/postgres-nio/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9Db25uZWN0aW9uL1Bvc3RncmVzQ29ubmVjdGlvbi5zd2lmdA==) | `17.14% <ø> (ø)` | | | [Sources/PostgresNIO/New/PostgresRowSequence.swift](https://codecov.io/gh/vapor/postgres-nio/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvUG9zdGdyZXNSb3dTZXF1ZW5jZS5zd2lmdA==) | `89.73% <ø> (ø)` | | | [Sources/PostgresNIO/New/PSQLRowStream.swift](https://codecov.io/gh/vapor/postgres-nio/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvUFNRTFJvd1N0cmVhbS5zd2lmdA==) | `84.54% <100.00%> (ø)` | |
MahdiBM commented 2 years ago

@fabianfett I see you did the swift bump yourself (https://github.com/vapor/postgres-nio/pull/310). I thought you'll get a notification from the review request but I assume you missed this 😅. This PR should be closed now I guess.

fabianfett commented 2 years ago

@MahdiBM urgh. so sorry. why did I miss this one? sorry!

MahdiBM commented 2 years ago

@fabianfett no problems 😅 i should've nudged you about it