Closed gwynne closed 1 year ago
I can confirm that this fixes the remaining crash for me 👍
Thanks @gwynne and @fabianfett !
@trasch Do you have a repro for the crash?
Merging #352 (7807f7a) into main (6e993d5) will decrease coverage by
0.01%
. The diff coverage is0.00%
.
It fixes the proximate crash, but it's not really dealing with the actual underlying problem; I defer to @fabianfett for the real solution.
Do you have a repro for the crash?
@fabianfett Not publicly available, and it uses internal databases that aren't available externally.
What I'm doing is running a few million PostGIS queries with a connection pool of size 50, so lots of parallel queries with short timeouts. I will try to create a test case that mimics this, but I will need some time. (And I hope that I didn't simply botch the connection pool...)
This hopefully solves the failed force-unwrap crash in the fix for #347 provided by #351.
cc @fabianfett @trasch