finestructure
commented
1 year ago We have another handful of other test that I believe are failing for the same underlying reason. We have logic that handles unique key violations as follows (I've noticed the clumsy catch and now replaced it with catch let error as ... where ... 🙂):
do {
try await Build(id: buildId,
versionId: trigger.versionId,
jobUrl: jobUrl,
platform: pair.platform,
status: .triggered,
swiftVersion: pair.swiftVersion)
.create(on: database)
} catch {
if let error = error as? PostgresError,
error.code == .uniqueViolation {
if let oldBuild = try await Build.query(on: database,
platform: pair.platform,
swiftVersion: pair.swiftVersion,
versionId: trigger.versionId) {
// Fluent doesn't allow modification of the buildId of an existing
// record, therefore we need to delete + create.
let newBuild = Build(id: buildId,
versionId: trigger.versionId,
buildCommand: oldBuild.buildCommand,
jobUrl: jobUrl,
platform: pair.platform,
status: .triggered,
swiftVersion: pair.swiftVersion)
try await database.transaction { tx in
try await oldBuild.delete(on: tx)
try await newBuild.create(on: tx)
}
}
} else {
throw error
}
}This seems to be falling through now to throw error.
Is there another/better way to handle unique key violation errors in the latest fluent-postgres-driver/postgres-kit?
(I could of course avoid the UK violation here by checking for existance first but the error case is very rare and I don't want to have to run the extra query on the happy path for every request.)
0xTim
gwynne
rausnitz
fabianfett
I'm not sure if this is a fluent-postgres-driver issue or one in postgres-kit - but FWIW, I can avoid it by pinning to
.package(url: "https://github.com/vapor/fluent-postgres-driver.git", exact: "2.6.2").We have a test that asserts on the error description when violating a not-null constraint:
With the latest version of fluent-postgres-driver this starts failing because the error message is now
The operation couldn’t be completed. (PostgresNIO.PSQLError error 1.),Of course the exact error message isn't important but the point of the test is to ensure that we have relevant information about an error in the logs.
We have another test that checks unique key violations:
That test is also failing due to that same new error message,
The operation couldn’t be completed. (PostgresNIO.PSQLError error 1.).Ideally, both violations would still be reported as such (with some detail as to which kind of constraint was violated) and also include the name of the constraint that was violated (if available).
Is there a way to recover this error information with the latest version of fluent-postgres-driver/postgres-kit?