This PR changes the behavior of close(). close() now closes a connection immediately. We introduce a closeGracefully() that now has the same behavior as close before. Since we never documented the old close behavior and it is unfortunate that close does depend on the remote server to fulfill all queries, we consider it okay to change the behavior in this way. The current behavior is harmful since there is currently no way to force close a connection. Users might be in a position to force close a connection if a server stops responding.
Alternative: close keeps graceful close behavior and we add a closeForcefully method instead
Fixes #370.
This PR changes the behavior of
close()
.close()
now closes a connection immediately. We introduce acloseGracefully()
that now has the same behavior as close before. Since we never documented the old close behavior and it is unfortunate that close does depend on the remote server to fulfill all queries, we consider it okay to change the behavior in this way. The current behavior is harmful since there is currently no way to force close a connection. Users might be in a position to force close a connection if a server stops responding.Alternative: close keeps graceful close behavior and we add a closeForcefully method instead