search

vapor / postgres-nio

🐘 Non-blocking, event-driven Swift client for PostgreSQL.
https://api.vapor.codes/postgresnio/documentation/postgresnio/
MIT License
305 stars 70 forks source link

Remove PSQLError.Code.clientClosesConnection #400

Closed fabianfett closed 11 months ago

fabianfett commented 11 months ago

Follow up to #383. This has breaking change which is fine, since we haven't cut a release after #383, which introduces the error code that we remove now.

codecov-commenter commented 11 months ago

Codecov Report

Merging #400 (e760f7c) into main (9a02d74) will increase coverage by 0.18%. The diff coverage is 57.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #400 +/- ## ========================================== + Coverage 48.97% 49.15% +0.18% ========================================== Files 108 108 Lines 8845 8839 -6 ========================================== + Hits 4332 4345 +13 + Misses 4513 4494 -19 ``` | [Files Changed](https://app.codecov.io/gh/vapor/postgres-nio/pull/400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/PostgresNIO/New/PSQLError.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvUFNRTEVycm9yLnN3aWZ0) | `80.00% <ø> (+0.97%)` | :arrow_up: | | [Sources/PostgresNIO/Postgres+PSQLCompat.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9Qb3N0Z3JlcytQU1FMQ29tcGF0LnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [...nection State Machine/ConnectionStateMachine.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvQ29ubmVjdGlvbiBTdGF0ZSBNYWNoaW5lL0Nvbm5lY3Rpb25TdGF0ZU1hY2hpbmUuc3dpZnQ=) | `62.28% <33.33%> (ø)` | | | [...urces/PostgresNIO/New/PostgresChannelHandler.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvUG9zdGdyZXNDaGFubmVsSGFuZGxlci5zd2lmdA==) | `84.62% <100.00%> (+0.02%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/vapor/postgres-nio/pull/400/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)
fabianfett commented 11 months ago

Expected API break detected by CI:

1 breaking change detected in PostgresNIO:
  💔 API breakage: var PSQLError.Code.clientClosesConnection has been removed