search

vapor / postgres-nio

🐘 Non-blocking, event-driven Swift client for PostgreSQL.
https://api.vapor.codes/postgresnio/documentation/postgresnio/
MIT License
304 stars 70 forks source link

Cleanup: Logging and some more #447

Open MahdiBM opened 6 months ago

MahdiBM commented 6 months ago
codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e9b90b2) 62.18% compared to head (cdddfe9) 62.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #447 +/- ## ========================================== + Coverage 62.18% 62.20% +0.02% ========================================== Files 124 124 Lines 9936 9936 ========================================== + Hits 6179 6181 +2 + Misses 3757 3755 -2 ``` | [Files](https://app.codecov.io/gh/vapor/postgres-nio/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Ξ” | | |---|---|---| | [...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvRXh0ZW5zaW9ucy9Mb2dnaW5nK1BTUUwuc3dpZnQ=) | `23.33% <ΓΈ> (ΓΈ)` | | | [...urces/PostgresNIO/New/PostgresChannelHandler.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvUG9zdGdyZXNDaGFubmVsSGFuZGxlci5zd2lmdA==) | `84.77% <100.00%> (ΓΈ)` | | | [...es/PostgresNIO/Utilities/PostgresJSONDecoder.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9VdGlsaXRpZXMvUG9zdGdyZXNKU09ORGVjb2Rlci5zd2lmdA==) | `50.00% <ΓΈ> (ΓΈ)` | | | [Sources/PostgresNIO/New/PSQLRowStream.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvUFNRTFJvd1N0cmVhbS5zd2lmdA==) | `86.33% <0.00%> (ΓΈ)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vapor/postgres-nio/pull/447/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)
fabianfett commented 5 months ago

Related #411.

fabianfett commented 5 months ago

Logging as well as Errors currently suck in PostgresNIO. I'm allowed to say that, as I was the one who implemented those. We should come up with a better logging and error plan first. Sadly I'm currently extremely low on time. @MahdiBM would you be interested in moving this forward?

MahdiBM commented 5 months ago

@fabianfett sure, but I don't have a plan of myself. How should we proceed?

MahdiBM commented 5 months ago

\<code-ql action is broken everywhere for now>