search

vapor / postgres-nio

🐘 Non-blocking, event-driven Swift client for PostgreSQL.
https://api.vapor.codes/postgresnio/documentation/postgresnio/
MIT License
304 stars 70 forks source link

PostgresClient implements ServiceLifecycle's Service #457

Closed fabianfett closed 4 months ago

fabianfett commented 4 months ago

PostgresClient should conform to ServiceLifecycle's Service to play nicely with the ecosystem.

gwynne commented 4 months ago

I don't see any actual conformance here?

codecov-commenter commented 4 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (17b23b1) 61.82% compared to head (725ac1d) 61.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #457 +/- ## ========================================== - Coverage 61.82% 61.81% -0.02% ========================================== Files 125 125 Lines 10012 10014 +2 ========================================== Hits 6190 6190 - Misses 3822 3824 +2 ``` | [Files](https://app.codecov.io/gh/vapor/postgres-nio/pull/457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/PostgresNIO/Pool/PostgresClient.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9Qb29sL1Bvc3RncmVzQ2xpZW50LnN3aWZ0) | `0.00% <0.00%> (ø)` | |