search

vapor / postgres-nio

🐘 Non-blocking, event-driven Swift client for PostgreSQL.
https://api.vapor.codes/postgresnio/documentation/postgresnio/
MIT License
321 stars 75 forks source link

Make PostgresClient API #460

Closed fabianfett closed 7 months ago

codecov-commenter commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c75349f) 61.86% compared to head (8c24d1f) 61.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #460 +/- ## ========================================== - Coverage 61.86% 61.82% -0.05% ========================================== Files 125 125 Lines 10014 10019 +5 ========================================== - Hits 6195 6194 -1 - Misses 3819 3825 +6 ``` | [Files](https://app.codecov.io/gh/vapor/postgres-nio/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Ξ” | | |---|---|---| | [Sources/PostgresNIO/Pool/PostgresClient.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9Qb29sL1Bvc3RncmVzQ2xpZW50LnN3aWZ0) | `0.00% <0.00%> (ΓΈ)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vapor/postgres-nio/pull/460/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)
fabianfett commented 7 months ago

The breaking changes are on SPI:

2 breaking changes detected in PostgresNIO:
  πŸ’” API breakage: func PostgresClient.query(_:logger:file:line:) has parameter 1 type change from Logging.Logger to Logging.Logger?
  πŸ’” API breakage: func PostgresClient.execute(_:logger:file:line:) has parameter 1 type change from Logging.Logger to Logging.Logger?