search

vapor / postgres-nio

🐘 Non-blocking, event-driven Swift client for PostgreSQL.
https://api.vapor.codes/postgresnio/documentation/postgresnio/
MIT License
321 stars 75 forks source link

Fix multiple array type mapping mistakes and add missing date and time array types #463

Closed gwynne closed 7 months ago

gwynne commented 7 months ago
codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 61.70%. Comparing base (dc9caf8) to head (fc155c1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #463 +/- ## ========================================== - Coverage 61.82% 61.70% -0.12% ========================================== Files 125 125 Lines 10019 10030 +11 ========================================== - Hits 6194 6189 -5 - Misses 3825 3841 +16 ``` | [Files](https://app.codecov.io/gh/vapor/postgres-nio/pull/463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [...s/PostgresNIO/New/Data/Array+PostgresCodable.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9OZXcvRGF0YS9BcnJheStQb3N0Z3Jlc0NvZGFibGUuc3dpZnQ=) | `72.00% <100.00%> (+0.28%)` | :arrow_up: | | [Sources/PostgresNIO/Data/PostgresDataType.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9EYXRhL1Bvc3RncmVzRGF0YVR5cGUuc3dpZnQ=) | `55.18% <20.00%> (-1.02%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/vapor/postgres-nio/pull/463/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)
gwynne commented 7 months ago

Note: There are no new tests because the effect of the missing mappings is not visible from within PostgresNIO itself; it affects PostgresKit due to hacks in that package which make atypical use of the array type mappings.