vapor / postgres-nio

🐘 Non-blocking, event-driven Swift client for PostgreSQL.
https://api.vapor.codes/postgresnio/documentation/postgresnio/
MIT License
321 stars 75 forks source link

Enable StrictConcurrency checking #483

Closed fabianfett closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.99%. Comparing base (6c3d0a9) to head (290e244).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #483 +/- ## ======================================= Coverage 54.98% 54.99% ======================================= Files 127 127 Lines 10155 10155 ======================================= + Hits 5584 5585 +1 + Misses 4571 4570 -1 ``` | [Files](https://app.codecov.io/gh/vapor/postgres-nio/pull/483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Ξ” | | |---|---|---| | [Sources/ConnectionPoolModule/ConnectionPool.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/483?src=pr&el=tree&filepath=Sources%2FConnectionPoolModule%2FConnectionPool.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Db25uZWN0aW9uUG9vbE1vZHVsZS9Db25uZWN0aW9uUG9vbC5zd2lmdA==) | `94.49% <ΓΈ> (ΓΈ)` | | | [...olModule/ConnectionPoolObservabilityDelegate.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/483?src=pr&el=tree&filepath=Sources%2FConnectionPoolModule%2FConnectionPoolObservabilityDelegate.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Db25uZWN0aW9uUG9vbE1vZHVsZS9Db25uZWN0aW9uUG9vbE9ic2VydmFiaWxpdHlEZWxlZ2F0ZS5zd2lmdA==) | `81.81% <ΓΈ> (ΓΈ)` | | | [...stgresNIO/Message/PostgresMessage+Identifier.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/483?src=pr&el=tree&filepath=Sources%2FPostgresNIO%2FMessage%2FPostgresMessage%2BIdentifier.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9NZXNzYWdlL1Bvc3RncmVzTWVzc2FnZStJZGVudGlmaWVyLnN3aWZ0) | `33.33% <ΓΈ> (ΓΈ)` | | | [...ces/PostgresNIO/Utilities/PostgresError+Code.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/483?src=pr&el=tree&filepath=Sources%2FPostgresNIO%2FUtilities%2FPostgresError%2BCode.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9VdGlsaXRpZXMvUG9zdGdyZXNFcnJvcitDb2RlLnN3aWZ0) | `0.00% <ΓΈ> (ΓΈ)` | | | [Sources/PostgresNIO/Pool/PostgresClient.swift](https://app.codecov.io/gh/vapor/postgres-nio/pull/483?src=pr&el=tree&filepath=Sources%2FPostgresNIO%2FPool%2FPostgresClient.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9Qb3N0Z3Jlc05JTy9Qb29sL1Bvc3RncmVzQ2xpZW50LnN3aWZ0) | `0.00% <0.00%> (ΓΈ)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vapor/postgres-nio/pull/483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)
fabianfett commented 3 months ago

Breaking changes only in ConnectionPool:

No breaking changes detected in PostgresNIO

13 breaking changes detected in _ConnectionPoolModule:
  πŸ’” API breakage: struct NoOpConnectionPoolMetrics has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: constructor NoOpConnectionPoolMetrics.init(connectionIDType:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.startedConnecting(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.connectFailed(id:error:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.connectSucceeded(id:streamCapacity:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.connectionUtilizationChanged(id:streamsUsed:streamCapacity:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.keepAliveTriggered(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.keepAliveSucceeded(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.keepAliveFailed(id:error:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.connectionClosing(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.connectionClosed(id:error:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: func NoOpConnectionPoolMetrics.requestQueueDepthChanged(_:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  πŸ’” API breakage: typealias NoOpConnectionPoolMetrics.ConnectionID has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>