vapor / queues-redis-driver

A Redis implementation for https://github.com/vapor/queues
MIT License
23 stars 20 forks source link

Custom logger for Redis pool #28

Open kacperk opened 3 years ago

kacperk commented 3 years ago

Is your feature request related to a problem? Please describe. Currently, if I set LOG_LEVEL to debug for running vapor apps, all redis commands to check the job queue produce 2 log entries and if you consider that it is doing once each second per worker it produces a lot of logs. As a result, it is very hard to find anything usable in the log without grep.

Describe the solution you'd like It should be possible to set log level/custom logger for redis pool - something like:

app.queues.use(try .redis(url: redisUrl, logger: myCustomLogger))
0xTim commented 3 years ago

In general I'm against this. The whole design of swift-log and the ecosystem is a shared central logger and allowing this to be broken is likely to cause confusion. IMO the focus should be on cleaning up the logs so we don't have duplicates and enhancing the metadata provided to the logger to allow logging tools to better filter logs.

Happy to open it up for discussion however