search

vapor / queues

A queue system for Vapor.
MIT License
169 stars 41 forks source link

Add queue helpers to QueueContext #71

Closed ileitch closed 4 years ago

ileitch commented 4 years ago

Add queue and queues(_:) helpers to QueueContext so that jobs may also be dispatched from other jobs, just like they are currently dispatched from a Request (#71).

jdmcd commented 4 years ago

I think this is good but since we're introducing a new public protocol I want to get @tanner0101's input on it

ileitch commented 4 years ago

@tanner0101 Yep sounds good. Updated.

jdmcd commented 4 years ago

@ileitch while we're at it and have an open PR, could you snag this log issue? https://github.com/vapor/queues/blob/master/Sources/Queues/QueueWorker.swift#L34 (notice the extraneous space + ':')

ileitch commented 4 years ago

@ileitch while we're at it and have an open PR, could you snag this log issue? https://github.com/vapor/queues/blob/master/Sources/Queues/QueueWorker.swift#L34 (notice the extraneous space + ':')

Done. I also lowercased Job to match this log line: https://github.com/vapor/queues/blob/302a29b2b3410aac240908bc7995e20fead18459/Sources/Queues/Queue.swift#L85

jdmcd commented 4 years ago

Thank you! LGTM

tanner0101 commented 4 years ago

@ileitch could you update the PR title and body to be formatted as release notes? Release bot will automatically tag a new release once merged. You can see examples here: https://github.com/vapor/queues/releases.

ileitch commented 4 years ago

@ileitch could you update the PR title and body to be formatted as release notes? Release bot will automatically tag a new release once merged. You can see examples here: https://github.com/vapor/queues/releases.

Sure, updated.

tanner0101 commented 4 years ago

Thanks!

tanner0101 commented 4 years ago

These changes are now available in 1.1.0