search

vapor / queues

A queue system for Vapor.
MIT License
169 stars 41 forks source link

More informative error reporting about what job is failing #81

Open jhoughjr opened 4 years ago

jhoughjr commented 4 years ago

QueuesCommand.swift line 101: worker.queue.logger.error("Job run failed: (error)") yields uninformative errors like "Connection refused" with no context as to what actually failed. Logging the worker, I see it has some information about the job that would be useful.

Might relate to #79 possibly as without a delay, the logs fill with infinite retries of non-obvious origins. Possibly just logging the job might suffice.

jdmcd commented 4 years ago

You can use the error function to customize the error message if you'd like, although I agree that it would be nice to log out the data and other items with trace or debug levels

jhoughjr commented 4 years ago

I added something quick and dirty to see what could be done ie was the condition accessible at runtime. I might ponder it and put in a PR.