vapor / queues

A queue system for Vapor.
MIT License
169 stars 41 forks source link

Document database/fluent access from inside dequeue #9

Closed antonyharfield closed 5 years ago

antonyharfield commented 5 years ago

Could we add an example to the readme on how to access the database/fluent from the job please?

I haven't figured out what the best way would be... can we pass in a DatabaseConnectable as service? or is it possible to extend the JobContext to be DatabaseConnectable?

(If you have some examples then I would be willing to document it in the readme.)

jdmcd commented 5 years ago

Sorry about that - the README is out of date as everything is in pre-release. This is a good place to find the updated docs: https://github.com/vapor/documentation/pull/389

Regarding the database connection, I pass in container.pooledConnection(to: .mysql) (I’m on mobile so that might not be the correct syntax.)

antonyharfield commented 5 years ago

Thanks @mcdappdev. The updated docs worked for me!

jdmcd commented 5 years ago

Awesome!

proggeramlug commented 5 years ago

@mcdappdev can we get the readme updated though? I'm planning on referencing this package in my upcoming book, so it would be nice to not have the readers look through these issues for them to find the link to the documentation ;)

jdmcd commented 5 years ago

@proggeramlug I’m actually going to get rid of the readme soon to match the style of the other Vapor repos. All stuff will be in that docs PR

proggeramlug commented 5 years ago

Can the readme post a link then?

On May 12, 2019 at 6:33 PM, <Jimmy McDermott (mailto:notifications@github.com)> wrote:

@proggeramlug (https://github.com/proggeramlug) I’m actually going to get rid of the readme soon to match the style of the other Vapor repos. All stuff will be in that docs PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/vapor/jobs/issues/9#issuecomment-491634968), or mute the thread (https://github.com/notifications/unsubscribe-auth/ACDURMFJ6ZNHYYB4GLBZWRTPVCLLNANCNFSM4G6XD25Q).

-- Skelpo - hot software.

www.reviewsender.com http://www.reviewsender.com

www.skelpo.com https://www.skelpo.com info@skelpo.com mailto:info@skelpo.com

Skelpo Inc. 600 Third Ave 2nd Floor New York, NY 10016 USA Phone: + 1 213 233 9447

Skelpo UG (haftungsbeschränkt)

Bergstraße 5 D-58339 Breckerfeld Germany Phone: +49 2338 6171890

jdmcd commented 5 years ago

Oh yeah absolutely, once the docs are live this readme will have a link just like all of the others