search

vapor / service

📦 Dependency injection / inversion of control framework.
MIT License
85 stars 9 forks source link

Update internal variable name to match type #27

Closed siemensikkema closed 5 years ago

calebkleveter commented 6 years ago

I like this change, but it breaks the API. I have a few third-party services that implement the ServiceType protocol where I would have to fix this. I think we should wait for Service 2.0 to make this change or somehow do a deprecation (if that is possible in this case).

siemensikkema commented 6 years ago

@calebkleveter it's just the internal variable though so it's more like a suggestion. Xcode will use it for autocomplete but you can change it to anything you want.

rafiki270 commented 6 years ago

I like it too and don't think there are any breaking changes there ... ?

calebkleveter commented 6 years ago

Hm, didn't know that. In that case, I'm all for it!

penny-coin commented 5 years ago

Hey @siemensikkema, you just merged a pull request, have a coin!

You now have 118 coins.