search

vapor / sql-kit

*️⃣ Build SQL queries in Swift. Extensible, protocol-based design that supports DQL, DML, and DDL.
MIT License
248 stars 58 forks source link

Fix behavior of SQLColumn when "*" is specified as a column name #181

Closed gwynne closed 5 months ago

gwynne commented 5 months ago

These changes are now available in 3.31.1

This behavior was implemented in SQLUnqualifiedColumnListBuilder but actually belonged in SQLColumn itself. Thanks @ptoffy!

Fixes #180.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (14f4350) to head (edacc5b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 100 100 Lines 2635 2635 ========================================= Hits 2635 2635 ``` | [Files](https://app.codecov.io/gh/vapor/sql-kit/pull/181?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [...s/Prototypes/SQLUnqualifiedColumnListBuilder.swift](https://app.codecov.io/gh/vapor/sql-kit/pull/181?src=pr&el=tree&filepath=Sources%2FSQLKit%2FBuilders%2FPrototypes%2FSQLUnqualifiedColumnListBuilder.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9TUUxLaXQvQnVpbGRlcnMvUHJvdG90eXBlcy9TUUxVbnF1YWxpZmllZENvbHVtbkxpc3RCdWlsZGVyLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [Sources/SQLKit/Expressions/Basics/SQLColumn.swift](https://app.codecov.io/gh/vapor/sql-kit/pull/181?src=pr&el=tree&filepath=Sources%2FSQLKit%2FExpressions%2FBasics%2FSQLColumn.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9TUUxLaXQvRXhwcmVzc2lvbnMvQmFzaWNzL1NRTENvbHVtbi5zd2lmdA==) | `100.00% <100.00%> (ø)` | |