search

vapor / toolbox

Simplifies common command line tasks when using Vapor
MIT License
283 stars 85 forks source link

Update Swift Versions #456

Closed 0xTim closed 1 month ago

0xTim commented 2 months ago

Bumps the integration tests to 5.10 to match the template and the toolbox minimum Swift version to 5.8 to match Vapor

gwynne commented 2 months ago

We want to keep the toolbox compatible with 5.5 for users on old versions of macOS. I recently had to do a PR to restore that compatibility. There's no need to bump that minimum (though bumping the integration tests is a good idea).

0xTim commented 1 month ago

Done, no need for a release then

gwynne commented 1 month ago

@0xTim Fixing the CI requires adding the same "we now need an available database server for the template's tests" logic to the toolbox CI that I added to the template's CI (see https://github.com/vapor/template/blob/main/.github/workflows/test-template.yml#L51-L118)

0xTim commented 1 month ago

How the hell has this ever passed in the past

gwynne commented 1 month ago

Those tests didn't previously exist so there was nothing to fail.

0xTim commented 1 month ago

Ohh right, we ran tests but didn't do anything in them. Makes sense