search

vapor / vapor

💧 A server-side Swift HTTP web framework.
https://vapor.codes
MIT License
24.41k stars 1.44k forks source link

asyncBoot will no longer try booting server again if it is already booted #3195

Closed RussBaz closed 4 months ago

RussBaz commented 4 months ago

These changes are now available in 4.100.2

The synchronous boot function skips running the lifecycle handlers if the server is already booted. However, the async version ignored this check. I have added a small fix to add this check again.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.46%. Comparing base (11cdb29) to head (6e83023). Report is 24 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3195 +/- ## ========================================== + Coverage 76.86% 77.46% +0.59% ========================================== Files 211 210 -1 Lines 8119 8089 -30 ========================================== + Hits 6241 6266 +25 + Misses 1878 1823 -55 ``` | [Files](https://app.codecov.io/gh/vapor/vapor/pull/3195?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/Vapor/Application.swift](https://app.codecov.io/gh/vapor/vapor/pull/3195?src=pr&el=tree&filepath=Sources%2FVapor%2FApplication.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9WYXBvci9BcHBsaWNhdGlvbi5zd2lmdA==) | `84.30% <100.00%> (-3.56%)` | :arrow_down: | ... and [94 files with indirect coverage changes](https://app.codecov.io/gh/vapor/vapor/pull/3195/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)
RussBaz commented 4 months ago

Done. Please have a look again.